Sub Menu
Suche

Last Online
In order to view the online list you have to be registered and logged in.



We are a free and open
community, all are welcome.

Click here to Register

"Native" leecher banning

BeitragAuthor: taz » Do 29. Mai 2008, 18:36

Hi,

I think other modders might find this useful Bild

It's been ages since I've used a mod or official without added leecher detection mechanism. Now while working on my "mod generator" (getting closure to adding CA) I've noticed that applying :

Xman's use ConnectIP instead of GetIP() at CClientList::AttachToAlreadyKnown (i.e. :

Code: Alles auswählen
...
        if (sender){
            if (found_client->socket){
                if (found_client->socket->IsConnected()

// Contrib - fix
//                    && (found_client->GetIP() != tocheck->GetIP() || found_client->GetUserPort() != tocheck->GetUserPort() ) )
                    && (found_client->GetConnectIP() != tocheck->GetConnectIP() //Xman use ConnectIP instead of GetIP()
                    || found_client->GetUserPort() != tocheck->GetUserPort() ) )
// <-------- fix

                {
                    // if found_client is connected and has the IS_IDENTIFIED, it's safe to say that the other one is a bad guy
                    if (found_client->Credits() && found_client->Credits()->GetCurrentIdentState(found_client->GetIP()) == IS_IDENTIFIED){
                        if (thePrefs.GetLogBannedClients())
                            AddDebugLogLine(false, _T("Clients: %s (%s), Banreason: Userhash invalid"), tocheck->GetUserName(), ipstr(tocheck->GetConnectIP()));

...


results in banning a lot of AJ (and derived) as well as other leechers (identified as Nick thieves or via nick as probably unaware bad mods users via looking at verbose log).

If anyone finds this worth looking at - I've earned my 2 cents Bild
SharkX modder - less " free meals" only a CLICK away !
Requests for additional / changed features HERE Next version changelog
Benutzeravatar
taz
Stammgast
 
Beiträge: 438
Registriert: Do 29. Mär 2007, 07:30
Wohnort: Israel

BeitragAuthor: WiZaRd » Do 29. Mai 2008, 19:20

I dunno why this would help banning leechers... it simply makes the attach work correctly... and btw: the GetIP() is wrong/messed up in MANY more locations...
Bild

... 9 von 10 Stimmen im meinem Kopf sagen ich bin nicht verrückt... - die 10te summt die Melodie von TETRIS
Benutzeravatar
WiZaRd
Forenlegende
 
Beiträge: 3805
Registriert: Fr 7. Jan 2005, 19:28
Wohnort: The Realm of Magic

BeitragAuthor: Stulle » Do 29. Mai 2008, 19:26

yeah, exactly. in fact xman added it in various places... and he labels it as fix not as leecher ban code.

Stulle
Forenlegende
 
Beiträge: 1014
Registriert: So 5. Feb 2006, 09:55

BeitragAuthor: WiZaRd » Do 29. Mai 2008, 19:32

Well, I added that, too and IIRC someone also added it to the Morph code...
Anyways, it's a *delicate* issue though it has been addressed several times on the official board and if SomeSupport doesn't think it's worth fixing... who knows?
But btw: if the next Alpha test starts, we should try and grab all our ancient fixes and changes and post them to the Alpha forum 'cos pretty much everything we posted there did finally make it into 0.49a :)
Bild

... 9 von 10 Stimmen im meinem Kopf sagen ich bin nicht verrückt... - die 10te summt die Melodie von TETRIS
Benutzeravatar
WiZaRd
Forenlegende
 
Beiträge: 3805
Registriert: Fr 7. Jan 2005, 19:28
Wohnort: The Realm of Magic

BeitragAuthor: taz » Do 29. Mai 2008, 19:57

yeah, exactly. in fact xman added it in various places... and he labels it as fix not as leecher ban code.


As it was brought (as fix) here ...

Well, I added that, too and IIRC someone also added it to the Morph code...
Anyways, it's a *delicate* issue though it has been addressed several times on the official board and if SomeSupport doesn't think it's worth fixing... who knows?
But btw: if the next Alpha test starts, we should try and grab all our ancient fixes and changes and post them to the Alpha forum 'cos pretty much everything we posted there did finally make it into 0.49a :)


Most of those common fixes and optimizations were accumulated into the "vanilla" v0 (VS2005 based 0.49a pre features stage) of my "mod generation" - once done outcome SRCs (pre and post CA addition) will be published (contributed to modders community). If anyone is interested in the "pre featured version" - I'd be happy to post it (since I'm too fresh - I can't be sure of "true" credits earners, so I've used comments and credits from mods changes were taken from. All changes (to 0.49a) are wrapped by "// Contrib -" prefix and "// <----" suffix (I used Contrib notation to distinguish from my own code changes - that are less trust worthy)).
SharkX modder - less " free meals" only a CLICK away !
Requests for additional / changed features HERE Next version changelog
Benutzeravatar
taz
Stammgast
 
Beiträge: 438
Registriert: Do 29. Mär 2007, 07:30
Wohnort: Israel

BeitragAuthor: dlarge500 » Do 29. Mai 2008, 20:10

I think this is a good idea, you get feedback about the changes and whether they do sense or are rather bad. Bild
__________________
Sys1: Asus P5Q-E | Intel Q9650 | 4 GB RAM DDR800| 1x Super Talent 64GB SSD | 1x Samsung HD103UJ 1TB | ATI 4870 | Windows 7 64Bit
Sys2: Gigabyte MA790X-UD4P | AMD X2 550 | 2x Seagate ST31500341AS 1,5TB | 4 GB RAM DDR800 | nVidia 9400GT | Win Vista 32Bit
Sys3: PoV ION330 | 4GB RAM Corsair | nVidia 9400GT | WD WD10EADS 1TB | Windows 7 64Bit

dlarge500
Stammgast
 
Beiträge: 432
Registriert: Sa 10. Mär 2007, 15:49
Wohnort: Mulihausen

BeitragAuthor: Tuxman » Do 29. Mai 2008, 20:30

[Off-Topic, thus German]

whether they do sense


Dieses, nur dieses eine Mal wäre "make sense" richtig gewesen.
Schade.

Bild

[/Off-Topic]
Ein intelligenter Mensch ist manchmal gezwungen, sich zu betrinken, um Zeit mit Narren zu verbringen.
(E. Hemingway)
Benutzeravatar
Tuxman
Forenlegende
 
Beiträge: 4183
Registriert: Sa 8. Jan 2005, 02:16

BeitragAuthor: Stulle » Do 29. Mai 2008, 20:38

yeah wiz, might really be worth it. however, i am not much into fixing official bugs cause i usually concentrate on other things unless something really goes wrong. yours and xmans might really need some nagging to be added.
what we should also do is ask SS to add something to kill sx-leechers. we are already banning aggressive clients and i think not replying sx requests is also somehow aggressive, huh?

Stulle
Forenlegende
 
Beiträge: 1014
Registriert: So 5. Feb 2006, 09:55

BeitragAuthor: WiZaRd » Fr 30. Mai 2008, 07:25

Not aggressive but simply unfair and stupid... leecher behaviour, indeed...
Bild

... 9 von 10 Stimmen im meinem Kopf sagen ich bin nicht verrückt... - die 10te summt die Melodie von TETRIS
Benutzeravatar
WiZaRd
Forenlegende
 
Beiträge: 3805
Registriert: Fr 7. Jan 2005, 19:28
Wohnort: The Realm of Magic


Zurück zu Entwicklung

Wer ist online?

Mitglieder: 0 Mitglieder

cron